search

aespinosa / cookbook-kube

Custom Chef resources to launch a Kubernetes cluster
https://supermarket.chef.io/cookbooks/kube
Apache License 2.0
32 stars 20 forks source link

Add missing configuration options for components #13

Closed lchi closed 8 years ago

lchi commented 8 years ago

Adds some configuration options that were likely added recently. I needed to use --leader-elect but decided that it might be better just to add everything listed in the docs (kube-apiserver docs for example).

There's a lot of changes so please let me know what I can do to make this easier to merge. As an aside I can see why you chose not to render default parameters :)

Thanks again for the cookbook!

aespinosa commented 8 years ago

Thanks. Looks like there's no options that were removed. I'll cut a minor bump for the release.

lchi commented 8 years ago

No problem!

One question I had - as new versions of Kubernetes are released, what is the right approach for supporting options that may be added/removed in the future? Would this cookbook expose the options for the latest released version? Thanks!

aespinosa commented 8 years ago

Hi,

Docs seems to be automatically generated by some Go framework from the source. Ideally, I would like to have some bot that runs against it and opens an issue at the very least.

Or completely do away with each commandline option as a resource property and just have a single options property that encompasses everything.

dy-dx commented 8 years ago

Thanks for this. @aespinosa could you cut a new release containing these changes?

aespinosa commented 8 years ago

sorry for not releasing soon @dy-dx , my workstation's flaking recently. just found a window that it worked.

now release as 1.1.0 in the supermarket

dy-dx commented 8 years ago

Thanks a lot!