search

aesqe / firefox-downloads-sidebar

A Firefox web extension that displays a list of your recent downloads in the sidebar
https://addons.mozilla.org/en-US/firefox/addon/downloads-sidebar/
MIT License
17 stars 3 forks source link

Variable Speed and Time Indicators. Version 1.0 #14

Closed josalhor closed 5 years ago

josalhor commented 5 years ago

Hello again!

I've got a new pull request with a few improvements. This time I've updated the plugin so it reports remaining time in minutes, seconds, hours and over a day of remaining time.

I've also updated the speed measurements so it checks for KB/s, MB/s, GB/s.

Some other sanity/clarity checks have been added. I propose (and add in the pull request) the version of the extension to bump to 1.0. I believe the extension to be stable enough and updated enough that the bump version is justified, it is not like the extension is unstable or in beta.

Let me know what you think!

josalhor commented 5 years ago

One other thing I want to comment before we merge is the style of the remaining time. The plural is used indepently of how much time there is left, so it is possible to see things like "1 minutes remaining".

One way to fix this would be to use a smaller representation like 1m remaining, that way we would avoid that problem. What do you think?

aesqe commented 5 years ago

Yeah, 1h, 1m, 1s is fine by me :)

If the user base continues to grow, we'll need to add translations and handle singular/plural differently anyway.

josalhor commented 5 years ago

Great! I pushed those changes!