handle failed downloads

aesqe / firefox-downloads-sidebar

A Firefox web extension that displays a list of your recent downloads in the sidebar

https://addons.mozilla.org/en-US/firefox/addon/downloads-sidebar/

MIT License

17 stars 3 forks source link

handle failed downloads #15

Closed lazymonkey2 closed 5 years ago

lazymonkey2 commented 5 years ago

hello, the extension does not handle correctly failed downloads: when a download fails I see in the sidebar the message "calculating", instead it should be "failed" or something similar. Also when I restart the download (using the default firefox downloads toolbar icon) the message still says "calculating" and is not updated (workaround: close and reopen the sidebar). thanks.

josalhor commented 5 years ago

I probably messed something up.

When you say failed you don't mean cancelling the download, you mean the server or the client fail to communicate anymore, right?

lazymonkey2 commented 5 years ago

yes, I didn't manually canceled the download, the server failed.

josalhor commented 5 years ago

Actually, i think I didn't mess anything up, I believe that case was not handled in the first place. That pull request should fix it.

lazymonkey2 commented 5 years ago

ok thanks!