aesqe / firefox-downloads-sidebar

A Firefox web extension that displays a list of your recent downloads in the sidebar
https://addons.mozilla.org/en-US/firefox/addon/downloads-sidebar/
MIT License
17 stars 3 forks source link

No content showing in downloads sidebar anymore... #19

Open oucil opened 4 years ago

oucil commented 4 years ago

Was working until recently, but no longer shows anything at all in the sidebar when open, while opening the normal downloads pop-up shows a full list.... even when I've had multiple downloads in the same session.

Started within the last month I would say, but can't be more specific, just noticed it yesterday. I'm on FFDE 70.0b6, Win10 1903 (18362.356). No other download or tab related add-ons, but I'll try disabling all and enabling this one alone just in case.

Kevin.

oucil commented 4 years ago

Just tried with all add-ons disabled, no joy, still not showing anything at all under sidebar, but showed as normal in the ctrl-J window. Initiated a new download to be sure it was during the current session as noted in your description of perms.

josalhor commented 4 years ago

Hi oucil,

Thanks for the report. I'm currently a little busy, I will probably take a look at this this weekend or next week. I'm on Ubuntu 18 and FF 68 right now and everything works as expected. I would suspect your beta build is causing this issue. If that is true, it is either a bug in the beta (possible, but unlikely), or a change on the API that is interfering with the add-on.

IRC it also worked properly on another FF 68 Win 10 I tried it on a few days ago. If you want to further debug this issue I would recommend you try it out on stable FF.

Josep

oucil commented 4 years ago

No worries, not a mission critical issue ;) Might be build related, but like you said more likely an upcoming change in 70.0, worth looking under the hood just in case.

Cheers, Kevin.

josalhor commented 4 years ago

Cannot replicate with 70.0.b8 and Windows 1803. Could you please try the stable build and tell me if you can replicate?

Would you feel comfortable Opening Browser Console (Ctrl + Shift + J) on your beta build and tell me if you see any weird message when you start a download?

Josep

McCovican commented 4 years ago

I'm still having the same issue with 70.0b10 (dev ed.), win7x64. Nothing at all showing up in the browser console though I'm afraid.

josalhor commented 4 years ago

I've figured out that it works on some cases (ex: right click and download an image, it shows up). However, when the download dialog shows up it doesn't actually respond, that's weird. I'm replicating this on 70.0b10 win 10 1809.

I'm actually starting to think this is a bug in Firefox. The reason is that in one case it is actually responding to the create callback, but not to the change one. Weird. Even more weird is that when I manually force a browser.downloads.search it returns (well it actually returns a promise, but whatever), an array without any downloads. I can't find any change in the API (please correct me if this is wrong), so I assume something in Firefox itself is failing. I see some really weird errors in the console itself.

josalhor commented 4 years ago

I've switched back to stable on 70.0.1 on Win 10 1903. Everything seems to be working fine now, have you had any issues lately? @oucil @McCovican

JeReT commented 3 years ago

I have a similar problem: It seems the downloads are getting cleared after a session. So I can see what I have downloaded recently (same items as the built in icon in the toolbar) but I cannot see what I have downloaded in previous sessions. When I "show all downloads" (open the library window of firefox) I can see all downloads however.

using Firefox 85.0.2 (64-Bit) and Download Sidebar 1.0.1.