aesqe / firefox-downloads-sidebar

A Firefox web extension that displays a list of your recent downloads in the sidebar
https://addons.mozilla.org/en-US/firefox/addon/downloads-sidebar/
MIT License
17 stars 3 forks source link

Downloads display #2

Closed rayman89 closed 6 years ago

rayman89 commented 6 years ago

Seems that now the addon is displaying the popup menu thing that appears when you press the native firefox downloads button. Could you make it so that it displays about:downloads instead? Currently there is a bug and every time you restart the browser the popup that shows the downloads gets cleared but about:downloads does not so I think it would be better to show that. Also like a guy on amo reviews says it would be nice to have the right click options on the sidebar as well like copy the url of the download clean the downloads etc.

aesqe commented 6 years ago

@rayman could you explain that first part a bit more, about the popup menu?

Unfortunately, I can't just display about:downloads in the sidebar, it doesn't work if I put it in an iframe (probably a security issue).

The clearing of the downloads is not a bug, it's how the latest downloads are implemented. As far as I can tell, extensions don't have access to the complete list of downloads, just those started in the current session. The moment you close Firefox, those downloads are no longer awailable.

Right-click menu is a bit more... fiddly to implement, because the default page context menu items are always visible, I can't hide them. I'll see if it makes more sense appending options to the right-click menu, or to a custom dropdown.

rayman89 commented 6 years ago

imagen

That's the popup thing I mention. The clearing of that info was reported in bugzilla and it's being discussed. If I'm not mistaken here was a WE addon that displayed any page on the sidebar when you clicked on it and some people reported to use it for displaying about:downloads. But i lacked features you addon had and sometimes it didn't load the page for some reason.

aesqe commented 6 years ago

v0.4:

rayman89 commented 6 years ago

Thanks a lot its looking great now. I wish It would show all the previous downloads as well not only the current session ones. Would that be possible sometime?

aesqe commented 6 years ago

@rayman89 unfortunately, as far as I can determine - no :/ It seems that the downloads API is limited to session downloads only.

rayman89 commented 6 years ago

Would the fix of this "bug" make it able to get the info from previous sessions? https://bugzilla.mozilla.org/show_bug.cgi?id=1255507

aesqe commented 6 years ago

@rayman89 Yes, I believe so 👍