search

aesqe / firefox-downloads-sidebar

A Firefox web extension that displays a list of your recent downloads in the sidebar
https://addons.mozilla.org/en-US/firefox/addon/downloads-sidebar/
MIT License
17 stars 3 forks source link

Download speed #4

Closed rayman89 closed 5 years ago

rayman89 commented 6 years ago

I noticed that the download sidebar is not showing the download speed could you add that please?

aesqe commented 6 years ago

@rayman89 I'll add it in v0.5, probably this week

josalhor commented 6 years ago

This was added already, right?

I think you should close this issue.

bastien30 commented 6 years ago

This was added already, right?

The download speed is not displayed on v0.5.1.

josalhor commented 6 years ago

My fault, you're right, I mistook it for the download progress. This weekend I will take a look at it. No promises.

josalhor commented 6 years ago

I'm very happy to announce that today I got remaining speed and remaining time working on my branch with the visual changes. See #12 .

When we merge you will see the changes too.

arelkin commented 5 years ago

Great work on the sidebar. Excellent that it also includes bookmarks, history and other FF chrome as options to be viewed.

I just installed and noticed that the download rate registered as "<0 MB/s" when I was d/l at a rate of (admittedly slow) 158k/s. (see screengrab) You should allow users the option to view d/l rate in either k/s or MB/s.

side-dowload-rate

josalhor commented 5 years ago

At the time I didn't think it was a big deal. I wanted to keep my changes simple. You're probably right that it should display something else than MB/s, but that certainly complicates the system a little bit more. Next week I'll take a look at it when I come back from a Congress.

However, I disagree that users should pick the metric. It should be completely transparent to the user.

Edit: I'll probably get on it in a few weeks as I'm way too busy right now to take a look at it, sorry for the delay. I'll do it, it is sitting on my inbox waiting.

harl commented 5 years ago

Good to know this is still being considered. Please at least make it say "<1 MB/s" (which is practically always the case for many people btw).

josalhor commented 5 years ago

Yeah sorry again for the delay, I'm with exams right now. I already have the design of how to implement this in my mind, I just have to find some time to actually do it and send a pull request. My exams finish on June 7, so expect a PR around that date.

harl commented 5 years ago

Good luck with those exams. Qapla'!

josalhor commented 5 years ago

14 Pull Request merges the changes I had in mind

aesqe commented 5 years ago

14 is merged and v1.0 of the extension is now available https://addons.mozilla.org/en-US/firefox/addon/downloads-sidebar/