search

aesterline / jruby-httpclient

A Ruby wrapper for Apache HTTPClient
Apache License 2.0
23 stars 6 forks source link

Support for multi-value headers, HEAD, OPTIONS & PATCH (for MRI) #3

Closed spiegela closed 13 years ago

spiegela commented 13 years ago

Here's my latest. I made a couple more changes to the headers to use the Apache lib's iterator, and be more RFC compliant. JRuby-HTTPClient now passes all of the Faraday tests with the adapter I've just committed--except HTTP PATCH support for JRuby.

The HTTP PATCH command isn't supported by the Apache lib yet, so I've included support for to MRI, but not JRuby.

The HTTP OPTIONS command in the Apache lib doesn't support an entity for some reason... if anyone actually tries to use that.

One thing I haven't done (but thought about) is support for multi-part requests for file uploads and such....

-Aaron

aesterline commented 13 years ago

That is cool about Faraday. I have thought about writing an adapter myself. Let me know if it gets merged into Faraday.