Fix #68, parse Boolean fields for @Params

aesteve / nubes

Annotation layer on top of Vert.x 3

Apache License 2.0

121 stars 35 forks source link

Closed morteza closed 7 years ago

morteza commented 7 years ago

Fix #68 (parse boolean fields in @Params).

aesteve commented 7 years ago

Thank you so much.

I'll just get your work, make sure everything's fine, then merge it & release a new version.

aesteve commented 7 years ago

God, github is completely broken... Maybe that's because you deleted your fork ? Idk... but :

curl -L https://github.com/aesteve/nubes/pull/71.patch

doesn't show anything, I can't review your pull request locally. I have to merge blindly

aesteve commented 7 years ago

Works fine. I'll release a new version. Thanks again for the pull request.

morteza commented 7 years ago

I'm really sorry, I thought it keeps everything intact. My mistake. I'll create a new fork for future requests.

aesteve commented 7 years ago

No please don't be sorry, it was a very good contribution, much appreciated