search

aesteve / nubes

Annotation layer on top of Vert.x 3
Apache License 2.0
120 stars 35 forks source link

Update to 3.5.1 #77

Closed johnfg2610 closed 6 years ago

johnfg2610 commented 6 years ago

I have run the tests and they all seem to be passing just fine. image I've fixed the auth handler and updated relevant classes. I have also updated the grade distribution to the latest version(4.6) as well as sonarqube and bintray.

johnfg2610 commented 6 years ago

am i correct in thinking the tests are ment to show some errors?(im new to unit tests although im fairly sure i got more work todo)

aesteve commented 6 years ago

Thanks a lot for your amazing work. I did not receive any notification about it that's why I missed it.

I'll take a look more in details (and run the tests locally), but you unfortunately removed the documentation folder, can you add it back ? Thanks.

johnfg2610 commented 6 years ago

Added the files back

aesteve commented 6 years ago

I tested your work, and it also works with 3.5.2.

Thanks a lot for your amazing work. I'll accept your PR, so that it "counts" as a contribution, then I'll upgrade to 3.5.2.

Thanks again.