aesteve / vertx-sse

Add support for Server-Sent-Events in Vert.x Web
Apache License 2.0
47 stars 13 forks source link

fix(retry): retry field is retry not delay #10

Closed ctranxuan closed 7 years ago

ctranxuan commented 7 years ago

The W3C SSE specification for the retry is to send "retry" as field. Current implementation was returning "delay" instead.

codecov-io commented 7 years ago

Codecov Report

Merging #10 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #10   +/-   ##
=========================================
  Coverage     88.75%   88.75%           
  Complexity       63       63           
=========================================
  Files            10       10           
  Lines           169      169           
  Branches         19       19           
=========================================
  Hits            150      150           
  Misses           10       10           
  Partials          9        9
Impacted Files Coverage Δ Complexity Δ
...tx/ext/web/handler/sse/impl/SSEConnectionImpl.java 87.09% <0%> (ø) 28 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 79c3087...417af9a. Read the comment docs.

aesteve commented 7 years ago

Thanks a lot for the PR !

ctranxuan commented 7 years ago

You're welcome :)