search

aesteve / vertx-sse

Add support for Server-Sent-Events in Vert.x Web
Apache License 2.0
47 stars 13 forks source link

Add Jenkinsfile for CI and fix for consecutive messages #14

Closed praetp closed 5 years ago

praetp commented 5 years ago

I noticed consecutive consumer callbacks would still see old messages as well. If the producer sends 'A', 'B', 'C', the consumer would receive

codecov[bot] commented 5 years ago

Codecov Report

Merging #14 into master will not change coverage. The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #14   +/-   ##
=========================================
  Coverage     89.72%   89.72%           
  Complexity       70       70           
=========================================
  Files            10       10           
  Lines           185      185           
  Branches         20       20           
=========================================
  Hits            166      166           
  Misses           11       11           
  Partials          8        8
Impacted Files Coverage Δ Complexity Δ
...ertx/ext/web/handler/sse/impl/EventSourceImpl.java 91.22% <77.77%> (ø) 18 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 033d8cd...ed9beca. Read the comment docs.

aesteve commented 5 years ago

Hello and thanks a lot for your work.

I'm so sorry I missed your PR. Since I never noticed issue with SSE on the server, I forgot about it. I didn't even pay attention your PR was about the client, not the server.

Once again, thanks a lot for your work. I'm going to merge it, then delete the Jenkinsfile since the project is using travis and not Jenkins, but nevermind, thanks a lot for your interest and your work.