aesthetic-suite / framework

🎨 Aesthetic is an end-to-end multi-platform styling framework that offers a strict design system, robust atomic CSS-in-JS engine, a structural style sheet specification (SSS), a low-runtime solution, and much more!
https://aestheticsuite.dev
MIT License
203 stars 5 forks source link

Problem with 1.1.1 and webpack #11

Closed AndreyShpilevoy closed 7 years ago

AndreyShpilevoy commented 7 years ago

I updated from 1.0.1 to 1.1.1. And after that I receive an error:

Uncaught TypeError: __WEBPACK_IMPORTED_MODULE_1_aesthetic_adapter_jss___default.a is not a constructor
    at eval (eval at 74 (app.js:375), <anonymous>:14:71)
    at Object.74 (app.js:375)
    at __webpack_require__ (vendor.js:692)
    at fn (vendor.js:111)
    at eval (eval at 184 (app.js:15), <anonymous>:5:73)
    at Object.184 (app.js:15)
    at __webpack_require__ (vendor.js:692)
    at fn (vendor.js:111)
    at eval (eval at 295 (app.js:182), <anonymous>:6:80)
    at Object.295 (app.js:182)
    at __webpack_require__ (vendor.js:692)
    at fn (vendor.js:111)
    at eval (eval at 296 (app.js:190), <anonymous>:6:72)
    at Object.296 (app.js:190)
    at __webpack_require__ (vendor.js:692)
    at fn (vendor.js:111)
    at eval (eval at 298 (app.js:206), <anonymous>:5:77)
    at Object.298 (app.js:206)
    at __webpack_require__ (vendor.js:692)
    at fn (vendor.js:111)
    at eval (eval at 269 (app.js:62), <anonymous>:15:66)
    at Object.269 (app.js:62)
    at __webpack_require__ (vendor.js:692)
    at fn (vendor.js:111)
    at Object.675 (app.js:366)
    at __webpack_require__ (vendor.js:692)
    at webpackJsonpCallback (vendor.js:24)
    at app.js:1

It looks like some issue with aesthetic_adapter_jss export. Can you check it? Thank you.

milesj commented 7 years ago

I'm having no issues here. What does your setup look like?

Does this work outside of webpack?

AndreyShpilevoy commented 7 years ago

Here is my project with version 1.0.1 - https://github.com/AndreyShpilevoy/dem-afterlife If we update plugin version to 1.1.1 we will receive this error on npm start or nmp build.

I didn't try to use without webpack.

milesj commented 7 years ago

Thanks, will take a look.

Edit: Been messing around locally in my own project. Have had no issue bundling so far.

milesj commented 7 years ago

Ok, it looks like aesthetic-adapter-jss is returning { default: Object } instead of Object. Not sure why though, digging further.

milesj commented 7 years ago

Can you try the 1.1.2 version?

AndreyShpilevoy commented 7 years ago

Yep, this version fixed my problem. Thank you. Also,as suggestion, it's will be great to have possibility to check, what changes (and new possibilities) was included to new versions. Right now it looks only like:

Publish

  • aesthetic-adapter-aphrodite@1.1.2
  • aesthetic-adapter-css-modules@1.1.2
  • aesthetic-adapter-fela@1.1.2
  • aesthetic-adapter-glamor@1.1.2
  • aesthetic-adapter-jss@1.1.2
  • aesthetic-native@1.1.2
  • aesthetic-utils@1.1.2
  • aesthetic@1.1.2

without real explanation, what was fixed, or added, or changed.

Thank you.

milesj commented 7 years ago

Sweet, thanks for the report. Getting Lerna to work correctly has been a pain.

There is a changelog at the root: https://github.com/milesj/aesthetic/blob/master/CHANGELOG.md