aesthetic-suite / framework

🎨 Aesthetic is an end-to-end multi-platform styling framework that offers a strict design system, robust atomic CSS-in-JS engine, a structural style sheet specification (SSS), a low-runtime solution, and much more!
https://aestheticsuite.dev
MIT License
203 stars 5 forks source link

CID return from className generator #29

Closed jacksenior closed 6 years ago

jacksenior commented 6 years ago

The cid generator in src/style.js can generate random strings that start with numbers. classNames that start with numbers are ignored by the browser so when trying to user version 2.0+ on our prod environment styles get applied or not applied at random depending on whether the generator made a CID starting with a letter.

I tried to submit a pr to change the line to
c${Math.random().toString(32).substr(2)}${instanceID}

to force it to always start with a c. I get permission denied when I try to push my branch though?

luke-robertson commented 6 years ago

+1

luke-robertson commented 6 years ago

https://github.com/milesj/aesthetic/pull/30

milesj commented 6 years ago

Thanks for the report and for the fix!