aestimosolver / aestimo

Aestimo 1D Schrödinger-Poisson Solver
https://aestimosolver.github.io
GNU General Public License v3.0
52 stars 23 forks source link

New behavioral change, examples are running under folder with creating their own folders #13

Closed sblisesivdin closed 4 years ago

sblisesivdin commented 4 years ago

This is a solution for issue #11 and an easy solution for issue #10 . Now, when user runs aestimo.py or aestimo_eh.py: -> it goes config.py take the name of input file, -> then opens the input file at /examples directory, -> does calculations, -> save results to a new directory created under /examples directory named as output_filename -> save logfile into the same newly-created directory.

With this commits, all examples/simulations will have their own result and logfiles piled in their own directories.

h-hebal commented 4 years ago

Now, it is working fine, it would be easy if each example has its own folder containing all related files including the example file that run the simulation.

sblisesivdin commented 4 years ago

You are right. In addition to your suggestion, the "main target" must be any input file that can be run in any place. Therefore, all examples can be put into their folders and it will produce their output and log files in the same folder.

However, that needs more fundamental change. This change that I made recently, does not change the main working principle but it maintains to work in a folder, with separate result folders. I think it will be enough for the version 2.0 release.

In the past, everything was in the main folder. I want to arrange files in related folders. I also want to separate some calculator files into another folder. But it is a subject of another issue :)

sblisesivdin commented 4 years ago

If there is no more comments on this merge request, I will merge it soon.

sblisesivdin commented 4 years ago

What do you think about this @robochat ? Is this merge colliding with your past commit*?

*: https://github.com/aestimosolver/aestimo/commit/47463775ef78b5190598a4343b6ec7b5cbd2460d#diff-11e56bfdd78b0794b567ea95c974a069