search

aestimosolver / aestimo

Aestimo 1D Schrödinger-Poisson Solver
https://aestimosolver.github.io
GNU General Public License v3.0
52 stars 23 forks source link

Inconsistency of units in output files #42

Closed NN708 closed 1 year ago

NN708 commented 1 year ago

The units in output files are inconsistent with the description in README.md.

For potn.dat, position is in cm instead of m, and energy is in eV instead of J. For sigma.dat, charge density is in C/m^3 instead of e/m^2. There's no description for np.dat, but position is also in cm.

sblisesivdin commented 1 year ago

Thank you for the comment. Sorry for the late reply. I was on vacation. I will look at the issue. Mostly, I will mention the units in tutorials and the input and output files. You can also submit your pull requests if you want.

sblisesivdin commented 1 year ago

PR is merged as is. Thanks. I am closing the issue.