search

aeternity / AEXs

Aeternity expansions repository — application layer standards
10 stars 25 forks source link

Add NFT proposal #143

Closed arjanvaneersel closed 2 years ago

arjanvaneersel commented 2 years ago

When opening a pull request to submit a new AEX, please use the suggested template: https://github.com/aeternity/AEXs/blob/master/aex-X.md

marc0olo commented 2 years ago

@arjanvaneersel The suggestions somehow cannot deal with this. But in some sophia codeblocks the ``` on the bottom are missing. This breaks the formatting, There are multiple occurences.

Example: image

thepiwo commented 2 years ago

for me it looks good with the comments from @omar-saadoun and @marc0olo adressed

marc0olo commented 2 years ago

@arjanvaneersel I saw you accepted some changes. there is still the formatting issue I mentioned in my comment.

can we agree on AEX-141 @thepiwo, @omar-saadoun? it's the number of the issue and got most votes on discord.

if so you can also change the filename and the aexX and aex-X placeholders in the standard definition.

after that I think we are ready to go and can merge it finally =)

arjanvaneersel commented 2 years ago

@marc0olo There's no change request with your comments, at least I don't see a button to accept your comments.

marc0olo commented 2 years ago

Hi @arjanvaneersel, I am talking about the following comment: https://github.com/aeternity/AEXs/pull/143#issuecomment-995363684

If you address this and change the placeholders and file accordingly to fit the AEX-141 we can merge =)

marc0olo commented 2 years ago

@arjanvaneersel when will you be able to make the last changes? you can also provide me the rights to adjust this on your branch if you want.

how should we proceed with the implementation? I will probably find somebody of the team to tackle this if that is ok for you. we need to move forward a bit faster on that topic