search

aeternity / AEXs

Aeternity expansions repository — application layer standards
10 stars 25 forks source link

AEX-2: Consistent explanations of exceptions that can be thrown by each method #66

Closed davidyuk closed 4 years ago

shekhar-shubhendu commented 5 years ago

this doesn't seem like an issue but only a cosmetic fix. this will applied by removing the error details provided in some methods.

davidyuk commented 5 years ago

Why don't make AEX-2 more strict by setting possible exceptions for each method? Right now AEX-2 allows aepp.subscribe.address method to return Broadcast Failed exception, does it have sense?

shekhar-shubhendu commented 5 years ago

i think the error details are provided are enough and devs can follow through that. adding error types for each method will only add redundancy.

Right now AEX-2 allows aepp.subscribe.address method to return Broadcast Failed exception, does it have sense?

it will be removed and has been left there by mistake.

AndreasGassmann commented 5 years ago

Maybe I'm missing something, but there is already a list of possible errors included in AEX-2. Couldn't we simply also specify which methods can throw each of these errors?

shekhar-shubhendu commented 5 years ago

@AndreasGassmann the meaning part of the errors table defines exactly when the error must be thrown. and if possible I would not go all the way defining a list of errors for each method as this not only creates redundancy but will also create room for typos, errors. more generic the things are the better it would be in managing it.

davidyuk commented 5 years ago

it will be removed and has been left there by mistake

I have misunderstood it, what will be removed?

shekhar-shubhendu commented 4 years ago

it will be removed and has been left there by mistake

I have misunderstood it, what will be removed?

please ignore.