aeternity / ae_mdw

Aeternity Middleware in Elixir
26 stars 11 forks source link

Show accounts and time created in genesis block #1809

Open janmichek opened 4 months ago

janmichek commented 4 months ago

Initially reported here https://github.com/aeternity/aescan/issues/838 by @davidyuk

in https://aescan.io/keyblocks/0

https://testnet.aeternity.io/mdw/v3/key-blocks/0 https://testnet.aeternity.io/mdw/v3/key-blocks/0/micro-blocks

sborrazas commented 4 months ago

The data shown on /mdw/v3/key-blocks/0 matches the data from the node https://testnet.aeternity.io/v3/key-blocks/hash/kh_wUCideEB8aDtUaiHCtKcfywU6oHZW6gnyci8Mw6S1RSTCnCRu

Plus, that key block does not have any microblocks, you can tell because the next key-block has as "previous_block" the first key-block, so there are no micro blocks in between: https://testnet.aeternity.io/mdw/v3/key-blocks/1 (prev_hash == kh_wUCideEB8aDtUaiHCtKcfywU6oHZW6gnyci8Mw6S1RSTCnCRu)

davidyuk commented 4 months ago

I think the node won't expose it in a public api the same as other activities with no transaction. Currently, mdw exposes activities by account. In this case, it would be useful to have activities per block, which should include initial coin distribution in the genesis block.

sborrazas commented 4 months ago

I thought this was about /key-blocks and /micro-blocks endpoints returning the wrong data. If that wasn't what was intended please close the issue and open up a new one to add a feature to retrieve initial coin distribution in genesis blocks

davidyuk commented 4 months ago

Why do you need a separate issue for this?

sborrazas commented 4 months ago

This issue was about /key-blocks endpoint displaying the wrong data and missing micro-blocks. This wasn't the case, we can close it

davidyuk commented 4 months ago

Jan just showed the endpoint he uses, the main problem is that mdw is not exposing accounts created in the genesis block as stated in the title.

sborrazas commented 4 months ago

The /key-blocks endpoint does not expose the genesis accounts, but we can add a new endpoint that does. This is a new feature request