aeternity / aepp-base

Base æpp
https://base.aepps.com
ISC License
42 stars 24 forks source link

chore: ignore order in extract-css plugin #1485

Closed davidyuk closed 1 year ago

davidyuk commented 1 year ago

This PR disables set of warnings looking like

warning  
chunk 924 [mini-css-extract-plugin]
Conflicting order. Following module has been added:
 * css ./node_modules/css-loader/dist/cjs.js??clonedRuleSet-21.use[1]!./node_modules/@vue/vue-loader-v15/lib/loaders/stylePostLoader.js!./node_modules/postcss-loader/dist/cjs.js??clonedRuleSet-21.use[2]!./node_modules/sass-loader/dist/cjs.js??clonedRuleSet-21.use[3]!./node_modules/@vue/vue-loader-v15/lib/index.js??vue-loader-options!./src/components/AeButtonGroup.vue?vue&type=style&index=0&id=8efc9db6&prod&lang=scss&scoped=true&
despite it was not able to fulfill desired ordering with these modules:
 * css ./node_modules/css-loader/dist/cjs.js??clonedRuleSet-21.use[1]!./node_modules/@vue/vue-loader-v15/lib/loaders/stylePostLoader.js!./node_modules/postcss-loader/dist/cjs.js??clonedRuleSet-21.use[2]!./node_modules/sass-loader/dist/cjs.js??clonedRuleSet-21.use[3]!./node_modules/@vue/vue-loader-v15/lib/index.js??vue-loader-options!./src/components/AccountInline.vue?vue&type=style&index=0&id=aed401b8&prod&lang=scss&scoped=true&
   - couldn't fulfill desired order of chunk group(s) popup
   - while fulfilling desired order of chunk group(s) ui

The order of styles matters in css, but in our case most of the components using scoped, so the order of style imports shouldn't break anything, so the warning can be disabled. Alternativally, we can maintain the same order in ui and popup chunks but this would looks unobvious and would be hight possibility to get warnings back.

This PR is supported by the Æternity Crypto Foundation

github-actions[bot] commented 1 year ago

Deployed to https://pr-1485-aepp-base.stg.aepps.com