search

aeternity / aepp-base

Base æpp
https://base.aepps.com
ISC License
42 stars 24 forks source link

Deploy testcab/cors-anywhere #1489

Closed davidyuk closed 9 months ago

davidyuk commented 1 year ago

https://hub.docker.com/r/testcab/cors-anywhere

github-actions[bot] commented 1 year ago

Deployed to https://pr-1489-aepp-base.stg.aepps.com

davidyuk commented 1 year ago

This container is needed for https://github.com/aeternity/aepp-base/pull/1490. @mmpetarpeshev can you deploy it somewhere the proper way? (like cors-anywhere.aepps.com) It also may be used by Superhero Wallet in future to retrieve aepps details.

Meanwile this PR needs to remain opened 🙃

mmpetarpeshev commented 1 year ago

This container is needed for #1490. @mmpetarpeshev can you deploy it somewhere the proper way? (like cors-anywhere.aepps.com) It also may be used by Superhero Wallet in future to retrieve aepps details.

Meanwile this PR needs to remain opened 🙃

@dincho support this service. If he prefers I do it. Will take a look, but let's sync with him first. The pipelines don't support draft PRs.The GitHub events are important here. I see only PR sync pipelines, which means something was wrong with the GitHub workflow. We can sync over chat what and how you did it.

dincho commented 9 months ago

No. This is wrong in so many cases. I won't deploy a (practically) public proxy to our environments. All the applications that wants to be listed in base app browser should support CORS configuration, either wildcard but better base app specific.