search

aeternity / aepp-calldata-js

Aeternity data serialization library
ISC License
3 stars 4 forks source link

Add support for `AENSv2.pointee`, `AENSv2.name` types #251

Closed davidyuk closed 6 months ago

davidyuk commented 9 months ago

depends on https://github.com/aeternity/aepp-calldata-js/pull/258

closes #210

based on https://github.com/aeternity/aeternity/pull/4056

AENSv2 in aesophia looks implemented in https://github.com/aeternity/aesophia/pull/426.

This PR is supported by the Æternity Crypto Foundation

hanssv commented 9 months ago

There hasn't been any general demand for such a branch - but I had it locally - it is now pushed to aesophia_cli

dincho commented 9 months ago

To test it properly we need a version of aesophia_cli that supports AENSv2.

to be more specific, a released version after initial/draft tests :)

dincho commented 9 months ago

Thanks for the implementation @davidyuk it looks straight forward so far. Thanks to @hanssv for BC :)

davidyuk commented 7 months ago

As I understand, bytes(x) have a mandatory prefix of two bytes (FateTag.OBJECT, FateTag.OTYPE_BYTES), but this prefix looks missing in case of decoding AENSv2.name value with DataPr. The first two bytes get lost because of https://github.com/aeternity/aepp-calldata-js/blob/a70ea77d87fddd73047031dd75835c5e5a21b851/src/Serializers/BytesSerializer.js#L19

The issue https://github.com/aeternity/aesophia/issues/498 looks related. I'm not sure how to proceed here.

dincho commented 7 months ago

258 has been merged, feel free to rebase this PR to get it in as well