aeternity / aepp-components

deprecated: aepp-components to be used in all aepps.
ISC License
41 stars 14 forks source link

Invalid meaning of type property of AeButton #117

Open davidyuk opened 6 years ago

davidyuk commented 6 years ago

HTML Button element has a type attribute, AeButton should be able to proxy value of this attribute to the underlying Button component, but actually type property is already used for AeButton style (color/background-color). We should rename type property of AeButton or introduce one more property for this reason.

In my opinion to use type property for type attribute of <button /> is better because it is consistent with HTML buttons.