aeternity / aepp-components

deprecated: aepp-components to be used in all aepps.
ISC License
41 stars 14 forks source link

Drop example code #139

Closed davidyuk closed 5 years ago

sadiqevani commented 6 years ago

The core/ folder is going to be removed. and be replaced by the 3 folders that you removed in there. So this pull-request is useless.

Also, please focus on working on other issues that are open right now, as you can see, i'm currently tackling this section.

davidyuk commented 6 years ago

constants and mixins is good enough to be in src folder, instead of stubs that you have made there. Later you can refactor some components and drop constants folder, but currently to move them somewhere has no sense. This PR brings back the state of the master branch.

ghost commented 6 years ago
  1. This pull-request does multiple things
    • Removes example code
    • Renames other things uselessly
    • Generalises the mixins events -> helpers which its a bad idea to include a bundle of all mixins in a single file, as specific components have specific needs
    • I'm going to be dropping some stuff for the future, constants and some other things that are not needed.

So in general I'll handle the moving of example code for:

to a folder called contributions where .md files are going to be defining contributions rules for specific areas for the components.

davidyuk commented 6 years ago

Renames other things uselessly

You have made actually the same in #120 and you have don't prove that it needs to do, why now I should prove it? This PR reverts the state of the master branch, it is enough to merge this PR.

Generalises the mixins events -> helpers which its a bad idea to include a bundle of all mixins in a single file, as specific components have specific needs

I would like to merge master into develop branch. In the master branch, helper mixin contains only forwardEvent method.