Closed davidyuk closed 5 years ago
constants
and mixins
is good enough to be in src
folder, instead of stubs that you have made there. Later you can refactor some components and drop constants
folder, but currently to move them somewhere has no sense. This PR brings back the state of the master branch.
events -> helpers
which its a bad idea to include a bundle of all mixins in a single file, as specific components have specific needsSo in general I'll handle the moving of example code for:
to a folder called contributions
where .md files are going to be defining contributions rules for specific areas for the components.
Renames other things uselessly
You have made actually the same in #120 and you have don't prove that it needs to do, why now I should prove it? This PR reverts the state of the master branch, it is enough to merge this PR.
Generalises the mixins events -> helpers which its a bad idea to include a bundle of all mixins in a single file, as specific components have specific needs
I would like to merge master
into develop
branch. In the master branch, helper
mixin contains only forwardEvent
method.
The
core/
folder is going to be removed. and be replaced by the 3 folders that you removed in there. So this pull-request is useless.Also, please focus on working on other issues that are open right now, as you can see, i'm currently tackling this section.