search

aeternity / aepp-components

deprecated: aepp-components to be used in all aepps.
ISC License
41 stars 14 forks source link

AeDrop: Use @click instead of v-touch #149

Closed davidyuk closed 6 years ago

ghost commented 6 years ago

Any reasoning why you would like to change this back to click?

davidyuk commented 6 years ago

As I see, @click does the same as @tap of VTouch component. Seems that the external package is not necessary in this case.

davidyuk commented 6 years ago

@sadiqevani Ok, but if there any difference in behavior of v-touch @tap and @click? If not, so we shouldn't use v-touch in this case, because click/tap handling is already implemented in Vue.

davidyuk commented 6 years ago

If v-touch @tap and @click have the same behavior it is better to use @click because in the case if a developer uses only AeDrop component and tree shaking is enabled then built bundle will be smaller because it won't contain v-touch and hammerjs packages.

davidyuk commented 6 years ago

I can find only that tap fires faster than click when we don't have "width=device-width" viewport meta tag, but we have this tag in our apps. https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away