search

aeternity / aepp-components

deprecated: aepp-components to be used in all aepps.
ISC License
41 stars 14 forks source link

Add AeListItem from the Base app #152

Closed davidyuk closed 5 years ago

davidyuk commented 6 years ago

Based on https://github.com/aeternity/aepp-identity/blob/7151b2c/src/components/ListItem.vue

ghost commented 6 years ago

this does not make sense to me overall with the way I am thinking that components will interact with each other.

The component should be stateless and with not change behavior on request, I'll document things appropriately as always, but for now I'll continue and building functionality and later if we see things are not good, we can change them.

davidyuk commented 6 years ago

this does not make sense to me overall with the way I am thinking that components will interact with each other

So, please explain how components should interact with each other.

The component should be stateless and with not change behavior on request

AeListItem is stateless (it doesn't have data defined). On what request AeListItem changes its behavior?

later if we see things are not good, we can change them

This component is already used in the Base app, not necessary to reinvent it.

sadiqevani commented 5 years ago

Closing this based on the new version of this component: https://github.com/aeternity/aepp-components/pull/213