search

aeternity / aepp-components

deprecated: aepp-components to be used in all aepps.
ISC License
41 stars 14 forks source link

Refactor AeCheck #153

Closed davidyuk closed 6 years ago

davidyuk commented 6 years ago

Expected to be used with AeListItem from #152 like in Network settings screen of the Base app. Restored <input type="checkbox" /> behavior in Vue like in this examples, according to this guide. Some changes based on AeRadio component from the Base app.

ghost commented 6 years ago

Please don't modify styles that I've already done! If you have a proposal or change that makes sense would be best if there was a user-story first so I can find a solution based on what I was thinking about the components and its relationships with its overall parents/sibling components.

davidyuk commented 6 years ago

Components should be simple. Make them focus on a few simple things. Reuse other components inside your component. Design yours, so that other components can reuse it and create richer compositions. https://github.com/aeternity/aepp-components#component-complexity

AeCheck should be as simple as <input type="checkbox" />, not need to combine this component with the functionality of AeListItem. Also the Base app already uses AeRadio components with a similar interface (together with AeListItem), I don't see any reason to change it.