search

aeternity / aepp-components

deprecated: aepp-components to be used in all aepps.
ISC License
41 stars 14 forks source link

ae-icon too unflexible #164

Closed emilsomm closed 5 years ago

emilsomm commented 6 years ago

I would suggest to change the neutral option of the icon to color: inherit; and not color: #000000; This would truly be neutral, and we wouldn't have to overwrite it later. Which can be difficult.

On the explorer the components also need updating

see screenshot below from my latest contribution to the explorer. In this situation i would use the neutral option as described above to give it a relatable color.

bildschirmfoto 2018-09-25 um 16 57 17
davidyuk commented 6 years ago

In the current version of the components package we are using fill property to change icon color, it doesn't support inherit value. It can be implemented in a future version since AeIcon will be based on font file instead of inlined SVGs.

sadiqevani commented 5 years ago

See #219