search

aeternity / aepp-components

deprecated: aepp-components to be used in all aepps.
ISC License
41 stars 14 forks source link

fixing jest-cli issue and including it as a local package #169

Closed sadiqevani closed 6 years ago

sadiqevani commented 6 years ago

There is an issue with tests for people who don't have jest-cli installed globally, so i'm including it as a dev dependency.

davidyuk commented 6 years ago

What particular issue do they have? I don't have jest installed globally, but npm run unit in components repository works well.

sadiqevani commented 6 years ago

jest-cli wasn't being resolved in the node_modules folder.

davidyuk commented 6 years ago

Is npx jest works without installing of jest-cli? I can't reproduce this problem.

sadiqevani commented 6 years ago

@davidyuk yep works.

I'll update the npm scripts to run jest through npx

sadiqevani commented 6 years ago

@davidyuk seems the issue was within my node_modules folder, I'll close this pull-request.