search

aeternity / aepp-components

deprecated: aepp-components to be used in all aepps.
ISC License
41 stars 14 forks source link

Clear global styles #184

Closed davidyuk closed 5 years ago

davidyuk commented 5 years ago

Today I have added new components package to the Base app, and I ran into a problem with global styles of this package: they break stuff in the Base app, especially styles for <a>.

So, I propose to define as less as possible styles globally to avoid this problem, and make components package more compatible with other components packages.

davidyuk commented 5 years ago

So, a new quality requirement for components package: they shouldn't pollute global styles except normalize.css and some light changes.

If I want to use components from this package in an existing application (we have about 10 applications that in future might use this package), this components shouldn't break already existing stuff.

I will continue to work without this global styles in v3 branch if lack of global styles breaks something in the components package, I will send a PR or update this one.

sadiqevani commented 5 years ago

I'm closing this on favor of this solution : https://github.com/aeternity/aepp-components/pull/194