Closed sadiqevani closed 5 years ago
enhance/ae-input-data-change
We are using git flow, so please check this and name branches accordingly.
@davidyuk
Any update on this?
@davidyuk
Internally in components package, I think we should build a set of input components that should look similar (they all should have a bright border at the left side and so on), for this purpose I propose to extract an component that will be used as wrapper for other input, but this component shoulnd't implement itself as input to make it some simplier and isolated. This wrapper also can be exposed to users to allow them to build own inputs usign it.
This is similarly what I've been thinking as well, but to implement this it will create some breaking changes.
What I have in mind currently it would be to have the following structure:
ae-input
would be the wrapper for every input, and wont provide any functionality, except style changes / modificationseach subsequent input would be the actual <input />
tag, an example list of inputs would be:
Like this we can also deal with other similar type of components, like the select
html tag.
But the thing I don't wanna do is to start creating wrappers for everything, I think the <ae-input>
should provide a basic <input>
functionality, and then the extra inputs are just enhancing the input.
@sadiqevani how would this proposal make breaking changes?
Also I like this idea your propose
ae-input-plain ae-input-amount ae-input-domain ...
the only thing I can see that impacts this is what happens if we decide to remove or add a style to what the ae-input's have in common. Then it is a possible maintenance issue. Plus side is that its brainless to use. I would love to put this proposal to the team and let them vote...
@edwarddikgale
how would this proposal make breaking changes?
There are a few stuff I need to investigate and see if it makes sense.
For breaking stuff:
focus
state where the component has a border applied on the sides.ae-input-plain
is already a component, I'll need to change this to a more minimalistic version, which will break stuff in the base appBut I need to investigate if its doable and how we can do it without messing up.
slot
component inside if we need custom inputs