search

aeternity / aepp-components

deprecated: aepp-components to be used in all aepps.
ISC License
41 stars 14 forks source link

changing files to be single-file, structuring styles to have fallback… #210

Closed sadiqevani closed 5 years ago

sadiqevani commented 5 years ago

This pull request deals with the issue of having two separate components repository. The new npm package @aeternity/aepp-components-3 does not solve our issue and its slow in release and is a bit confusing.

I've turned the old components into a single .vue component so the scss in there gets bundled with the per-folder component, and also gets included in the aepp.components.css file so we don't need to use two different npm packages for the components.

@davidyuk I haven't tested on any application, and also we should have only one single npm package so we can do better transition.

davidyuk commented 5 years ago

The new npm package @aeternity/aepp-components-3 does not solve our issue

That issues with this package do we have? It works great in the Base app

sadiqevani commented 5 years ago

@davidyuk in what sense it works great? This is not a long-term solution, are we suppose to have:

For each major version?

I know it works, its just not a proper solution! We will go through with proper release versions and we'll export old components through the releases to keep backward compatibility.

People working with components are kinda confused at what they should import and foremost some people don't know where are the new components.

davidyuk commented 5 years ago

@aeternity/aepp-components-3 is a temporary solution for the Base app, later we will be able to publish v3 at @aeternity/aepp-components