aeternity / aepp-components

deprecated: aepp-components to be used in all aepps.
ISC License
41 stars 14 forks source link

add :active style of ae-button as :hover effekt for desktop support #216

Closed emilsomm closed 5 years ago

emilsomm commented 5 years ago
sadiqevani commented 5 years ago

@emilsomm

I'm not sure if the :hover state should have an opacity, the issue here is that when the button is also clicked and remains :focused it will apply the opacity, which in Mobile versions might keep the state like that until the user clicks somewhere else.

I think for the button state we should talk with @raymundjacobs and have two different states:

emilsomm commented 5 years ago

OK, we can discuss this with @raymundjacobs https://github.com/raymundjacobs today !

On 27. Nov 2018, at 12:05, Sadi Qevani notifications@github.com wrote:

@emilsomm https://github.com/emilsomm I'm not sure if the :hover state should have an opacity, the issue here is that when the button is also clicked and remains :focused it will apply the opacity, which in Mobile versions might keep the state like that until the user clicks somewhere else.

I think for the button state we should talk with @raymundjacobs https://github.com/raymundjacobs and have two different states:

:focued state should maybe apply opacity :hover state should maybe apply an increased box-shadow — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aeternity/aepp-components/pull/216#issuecomment-442018651, or mute the thread https://github.com/notifications/unsubscribe-auth/ATRuXrCU0-oqgW6Lx69esPjw0rsaN_Bcks5uzRx1gaJpZM4Yy0k8.

sadiqevani commented 5 years ago

I'm closing this PR, we can come back at this issue later.