search

aeternity / aepp-components

deprecated: aepp-components to be used in all aepps.
ISC License
41 stars 14 forks source link

ae-text primary color is not equal to button primary color #232

Open kenodressel opened 5 years ago

kenodressel commented 5 years ago

the primary text is #bd2a67 while the primary button color is #ff0d6a.

sadiqevani commented 5 years ago

@kenodressel this is on purpose.

kenodressel commented 5 years ago

Interesting. Maybe it would be nice to give the developer a choice as there is a wide variety of "primary" colors as documented in #165

sadiqevani commented 5 years ago

@kenodressel maybe we can do this on a future plan, but needs to be discussed with @raymundjacobs and also I would like to avoid making this component really complex and adding more props to change colors, etc.

sadiqevani commented 5 years ago

Also I think this is a design decision! If you think of the context in which ae-text will work, is under buttons and under primary colors, and having it the same as the background, does not make sense.

kenodressel commented 5 years ago

You can handle it as you desired I would appreciate if there is a possibility to model a headline in the ae primary color but i can also do it with css. So no worries.

sadiqevani commented 5 years ago

You can handle it as you desired I would appreciate if there is a possibility to model a headline in the ae primary color but i can also do it with css. So no worries.

@kenodressel the purpose of ae-text is not to replace p, span, h1, h2, h3, h4,h5, h6, but more like in case you need some custom paragraph styles, and don't really wanna use css to set these texts.

But I will see if we can update ae-text with more colors and applications.