search

aeternity / aepp-components

deprecated: aepp-components to be used in all aepps.
ISC License
41 stars 14 forks source link

AeIcon: Make it inline-flex only when it necessary #252

Open davidyuk opened 5 years ago

davidyuk commented 5 years ago

I have checked styleguide, looks it doesn't break any other components/examples.

sadiqevani commented 5 years ago

@davidyuk

Lets put this as an extra prop change (extra class that can be applied), rather than making it exclusively for primary.

davidyuk commented 5 years ago

Did you mean round instead of primary? Are this styles used somewhere else except round state? I can't find its usages.

sadiqevani commented 5 years ago

@davidyuk

I was thinking more of something like:

<ae-icon flex-center />
props: {
  flexCenter: Boolean
}
.ae-icon.flex-center {}

Adding those behavior modifications as class, so its not specific to one style.

davidyuk commented 5 years ago

No need to add this property, parent component can modify icon styles if it is really necessary, I don't see any other cases except round.