aeternity / aepp-components

deprecated: aepp-components to be used in all aepps.
ISC License
41 stars 14 forks source link

AeLabel help-type supporst all types (change suggestion to #56) #62

Closed acdbaykal closed 6 years ago

acdbaykal commented 6 years ago

This version of #56

acdbaykal commented 6 years ago

Hi @davidyuk, https://github.com/aeternity/aepp-components#component-css-classes

Putting some underscores in class names isn't complicated and imo it does communicate the purpose of the css class better.

It is hard to predict, how these components will be used by others. It isn't entirely out of question that some one may decide to use those types. However my main point would be, that consistency is important for us human beings. Since we have a naming/coloring theme we should implement that every where, fully. And I think #52 mirrors notion, since renaming the type from "Danger" was not requested out of technical inadequacy but consistency.