aeternity / aepp-governance

Aeternity Governance Aepp
https://governance.aeternity.com/
ISC License
2 stars 7 forks source link

poll verification fails after creation, as not indexed by mdw #145

Closed thepiwo closed 1 year ago

mradkov commented 4 years ago

Is this why this message appears:

05cb3e7e-3172-4368-8664-5de43743422e

thepiwo commented 4 years ago

it is, but suppressing the error message is not a solution here

kenodressel commented 4 years ago

I guess we should just make it less intrusive? also we should differentiate between we can not verify the poll correctness and we almost certainly know its not correct.

thepiwo commented 4 years ago

yes, either this or have a more reliable way to fetch contract bytecode

kenodressel commented 4 years ago

Any suggestions on a more reliable way? I guess we could save the contractCreateTxHash from the previous step and temporarily use it in the local storage for querying the TX directly from the node. This would only solve this issue for the creator though.

thepiwo commented 4 years ago

For the creator of the poll we can disable the check when the referral to the poll comes from the create page. Your suggestion is also fine. Or a new feature in the core could allow us to easily fetch the needed bytecode.

kenodressel commented 4 years ago

The question is how urgent is this issue, as a new core feature would probably take some time. I could also think of a middle ground as we can expect that this issue only appears in the first minutes of a poll being created. Basically make the warning in this case less intrusive (eg. integrate it into the site) and have it say "We can not verify this poll right now, please try again in a few minutes" and keep the current approach for polls where we know the bytecode does not match.

thepiwo commented 1 year ago

this was fixed already