search

aeternity / aepp-governance

Aeternity Governance Aepp
https://governance.aeternity.com/
ISC License
2 stars 7 forks source link

ci: change pipeline buld context #182

Closed mmpetarpeshev closed 1 year ago

kenodressel commented 1 year ago

I guess this uncovered another bug :) The CI should be running here (eg. if we change something on the CI) and if something is changed on contract repo, we need to re-deploy both, the frontend & backends :)

mmpetarpeshev commented 1 year ago

I guess this uncovered another bug :) The CI should be running here (eg. if we change something on the CI) and if something is changed on contract repo, we need to re-deploy both, the frontend & backends :)

We are running the pipelines only for changes in the required folder.Here is example : https://github.com/aeternity/aepp-governance/blob/master/.github/workflows/server-prod-mainnet-pipeline.yml#LL5C5-L6C31

kenodressel commented 1 year ago

I've seen the code that currently exists but when we look at the docker file we see a few other dependencies. And when there are changes to the CI, the CI should also run. Otherwise we don't know if it works right?

mmpetarpeshev commented 1 year ago
  1. About the other dependencies I can't say do we need something to be run . As far as I remember we wanted to run it per folder. If we have a new requirement it can be changed, np here.
  2. About the pipelines, really depends on the case, but usually, I'm testing with a test repo. That can be changed too.