search

aeternity / aepp-sdk-js

JavaScript SDK for the æternity blockchain
http://docs.aeternity.com/aepp-sdk-js/
ISC License
120 stars 59 forks source link

Make transaction names consistent between repositories #1145

Closed davidyuk closed 2 years ago

davidyuk commented 3 years ago

Make transaction names consistent between repositories

For example, "name pre-claim" transaction: https://github.com/aeternity/aepp-sdk-js/blob/289598c55ff6a9d9eef8b85030e0d1f901447123/es/tx/builder/schema.js#L184

https://github.com/aeternity/aepp-sdk-elixir/blob/a001b0eb264665623c9b05de25a71d1f13990679/lib/utils/transaction.ex#L32

https://github.com/aeternity/elixir-node/blob/d35613f5541a9bbebe61f90b8503a9b3416fe8b4/apps/aecore/lib/aecore/naming/tx/name_pre_claim_tx.ex#L1

https://github.com/aeternity/aesophia_aci_encoder/blob/41d0427391ad9c153a5af1a4dcb9b361c4f425b0/src/aeaci_aci.erl#L219

to avoid the stuff like:

export const TX_TYPES_MDW = {
   SpendTx: TX_TYPE.spend,
   ContractCallTx: TX_TYPE.contractCall,
   ContractCreateTx: TX_TYPE.contractCreate,
   NamePreclaimTx: TX_TYPE.namePreClaim,
   NameClaimTx: TX_TYPE.nameClaim,
   NameBidTx: TX_TYPE.nameClaim,
   NameUpdateTx: TX_TYPE.nameUpdate,
 };

https://github.com/aeternity/superhero-wallet/pull/951/files?short_path=5c093c4#diff-0453e03088f470724b3f8c7c0879c03547a84ec4bf1e0b0e241f4396243c6e08R16-R24

davidyuk commented 2 years ago

SDK choosed https://github.com/aeternity/aeserialization as a source of truth in https://github.com/aeternity/aepp-sdk-js/pull/1622