Figure out how to sign delegation signatures using aepp-wallet connection

aeternity / aepp-sdk-js

JavaScript SDK for the æternity blockchain

http://docs.aeternity.com/aepp-sdk-js/

ISC License

120 stars 59 forks source link

Figure out how to sign delegation signatures using aepp-wallet connection #1758

Closed davidyuk closed 1 year ago

davidyuk commented 1 year ago

Currently, it is not allowed to sign raw data using wallet.

I would pass its components as plain text to be able to validate it on the on wallet side, otherwise would be difficult to distinguish buffer with account address and contract address.

marc0olo commented 1 year ago

I guess that will be highly relevant for the UI of my proposed grant, right? https://forum.aeternity.com/t/new-wrapping-aens-names-into-aex-141-nfts/11214

subhod-i commented 1 year ago

Wallet does support signing raw data now. @CedrikNikita please confirm

marc0olo commented 1 year ago

@davidyuk it would be great if you can provide me a short example how to pass the raw data correctly to the wallet for a valid delegation signature for AENS names :)

CedrikNikita commented 1 year ago

Wallet does support signing raw data now. @CedrikNikita please confirm

Yes, but we are signing it by our own. And the topic here is related to make it possible with a sdk.

davidyuk commented 1 year ago

I've found a potential security vulnerability in the delegation signature for oracle query https://github.com/aeternity/aesophia/issues/474 https://github.com/aeternity/aesophia/issues/475 but it is not blocking