search

aeternity / aepp-sdk-js

JavaScript SDK for the æternity blockchain
http://docs.aeternity.com/aepp-sdk-js/
ISC License
120 stars 59 forks source link

Add mnemonic factory, remove hd wallet functions #1998

Closed davidyuk closed 2 months ago

davidyuk commented 2 months ago

closes https://github.com/aeternity/aepp-sdk-js/issues/1672

This PR is supported by the Æternity Foundation

If necessary, you can make a version of MemoryAccount not exposing a secret key by

class MemoryAccountProtected extends MemoryAccount {
  override secretKey: Encoded.AccountSecretKey = 'sk_hidden';
}
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.93%. Comparing base (be9963a) to head (10e7c89). Report is 2 commits behind head on develop.

Files Patch % Lines
src/account/LedgerFactory.ts 50.00% 0 Missing and 1 partial :warning:
src/account/MnemonicFactory.ts 97.29% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1998 +/- ## =========================================== + Coverage 82.90% 82.93% +0.03% =========================================== Files 105 105 Lines 3521 3458 -63 Branches 730 719 -11 =========================================== - Hits 2919 2868 -51 + Misses 303 295 -8 + Partials 299 295 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

davidyuk commented 2 months ago

@thepiwo As before I will build migration guide by commit descriptions starting with "BREAKING CHANGE: ...". But for some methods I won't have a good guide because I think they was not popular, like hd wallet methods.