aeternity / aescan

Block Explorer and Analytics Platform
ISC License
6 stars 3 forks source link

feat: Add smart contract verification #665

Closed janmichek closed 6 months ago

janmichek commented 7 months ago

Description

resolves #253 resolves #667

Demo

This is a simple happy path on how to verify contract All of the AEstudio sample examples should be tested @Liubov-crypto

https://github.com/aeternity/aescan/assets/15363559/b3f87649-f0ec-48d3-8e41-5fc653a6446b

Checklist:

github-actions[bot] commented 7 months ago

Deployed to https://pr-665-aescan.stg.service.aepps.com and https://pr-665-aescan-testnet.stg.service.aepps.com

Liubov-crypto commented 7 months ago

For me it trows an error:

errrr tttt

https://github.com/aeternity/aescan/assets/69896204/7884ee76-086d-42b8-b575-9e11577a4e44

maybe it was because I was not able to create and upload a proper file with smart contract with .aes at the end. I tried different redactors but can't do it on my Mac :(

janmichek commented 7 months ago

For me it trows an error:

errrr tttt 2024-02-15.5.07.31.mov

maybe it was because I was not able to create and upload a proper file with smart contract with .aes at the end. I tried different redactors but can't do it on my Mac :(

Ok, that's kind of an edge case. The browser should not allow you to select other files than .aes. You can still surpass it by selecting 'All files' in the browser's file selector. It's not that important now, but I will fix it.

janmichek commented 7 months ago

For me it trows an error:

errrr tttt 2024-02-15.5.07.31.mov

maybe it was because I was not able to create and upload a proper file with smart contract with .aes at the end. I tried different redactors but can't do it on my Mac :(

I fixed that. I found out there is a various error message structure form verifier service. It works, but it's kinda implementation workaround. I created an issue to improve it. It would be nice to process it before the release https://github.com/aeternity/aescan/issues/667

janmichek commented 6 months ago

@michele-franchi thanks for feedback. Working on it.

I fixed the folder drop. However there is some service issue. Reported here https://github.com/aeternity/smart-contract-verifier/issues/44

janmichek commented 6 months ago

I would keep consistency in the required messages:

I agree it was an inconsistent and bit funky. I aligned it in a different way

Liubov-crypto commented 6 months ago

I tried, but it doesn't work for me, probably because I can't create .aes file on my Mac:

https://github.com/aeternity/aescan/assets/69896204/0c579a7b-54b3-400c-9ca4-750a5c86513e

@janmichek could you please suggest me some other way to verify it?

janmichek commented 6 months ago

I tried, but it doesn't work for me, probably because I can't create .aes file on my Mac: 2024-03-06.6.11.49.mov

@janmichek could you please suggest me some other way to verify it?

  1. There was a small bug with selecting entry file through direct input. I fixed that
  2. please also test drag and drop functionality
  3. https://www.google.com/search?client=firefox-b-d&q=create+custom+suffix+text+file+on+mac
Liubov-crypto commented 6 months ago

Finally I was able to do smart contracts verification. It's working for me well on testnet. Also drag and drop functionality is working as expected. LGTM