aeternity / aescan

Block Explorer and Analytics Platform
ISC License
6 stars 3 forks source link

fix: When transaction is unavailable the app shows 500 error #675

Closed janmichek closed 5 months ago

janmichek commented 6 months ago

Description

fixes #674

Demo

https://github.com/aeternity/aescan/assets/15363559/3b27fa69-79c4-4723-9cad-ceb0116b99f2

Checklist:

github-actions[bot] commented 6 months ago

Deployed to https://pr-675-aescan.stg.service.aepps.com and https://pr-675-aescan-testnet.stg.service.aepps.com

Liubov-crypto commented 5 months ago

Looks good.

But I have a question: for example if I'm changing a little bit the Tx hash it will show me text: There is no data available, instead of 500 error. is this expected behaviour?

https://github.com/aeternity/aescan/assets/69896204/99b4643c-6b7c-474d-97db-94e839563edb

michele-franchi commented 5 months ago

@Liubov-crypto It's because the th_ you entered in the search bar is not a valid tx hash. If you try on mainnet with a valid tx hash from testnet you will get the not found screen.

janmichek commented 5 months ago

Yep this is how it was designed. It's first tested that the hash is even valid account hash. But I agree that would make more sense from user point of view to show that the such an account has not been found event the hash is not valid account hash