search

aeternity / aescan

Block Explorer and Analytics Platform
ISC License
6 stars 3 forks source link

feat: Wallet account view 4 #678

Closed janmichek closed 1 month ago

janmichek commented 5 months ago

Description

fixes #536

There are 2 minor UX issues I will try to resolve in the following (Portfolio) issue, so I don't block the review

  1. After successful wallet connection there is no loader when redirecting to connected account detail
  2. When clicking on Try again, the whole page gets reloaded, which is not necessary. Only scanning again should work, but for some reason it's not working https://github.com/aeternity/aescan/issues/572

Demo

https://github.com/aeternity/aescan/assets/15363559/64887a9e-5d48-4f4d-ad37-92793c2700ff

Checklist:

github-actions[bot] commented 5 months ago

Deployed to https://pr-678-aescan.stg.service.aepps.com and https://pr-678-aescan-testnet.stg.service.aepps.com

janmichek commented 5 months ago

Generally it looks good but I would adjust the following:

1. The "Connect Wallet" button should have the same height of the network switcher:
image

padding: var(--space-1); on the button solves it.

2. The "Exit Wallet" dropdown should be visually similar to the menu dropdowns.
image

Example:

image

Without the min-width of the other menu items.

3. When you connect the wallet and you refresh the page the connection is lost.

I have been discussing this with Denis. Currently is not possible to achieve this seamlessly. The app can remember last used account, but we cannot go over the user prompt to connect to the wallet again like on superhero.com Implementation-wise, the SDK can do something to simplify it, but fundamentally will stay the same.

For now, I suggest not to implement it, wait for SDK completion, and the implement the persistency of last logged address @michele-franchi

janmichek commented 1 month ago
  1. As I understood from the comments the button should have the same width:

but

2. There is no account icon:
   ![icon](https://private-user-images.githubusercontent.com/69896204/350337352-6312902c-8279-4117-9296-63ef97a57e4c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3MjUwMzgsIm5iZiI6MTcyMTcyNDczOCwicGF0aCI6Ii82OTg5NjIwNC8zNTAzMzczNTItNjMxMjkwMmMtODI3OS00MTE3LTkyOTYtNjNlZjk3YTU3ZTRjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIzVDA4NTIxOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVhNjYxNjFiNGY1YzFlNmIyNmZmODQ4YmE1NjNhODkzMmQ3MWU2MDQxOTg0MmE3ODgxMThjZWRkNDYxNDQwNmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.yn2sCLGbQiCh7wpGljRsW_CKPpOi5I0c1oKQkp0QeeY)

3. After I connect the wallet and refresh the page the connection is lost. As I understood currently it's not possible to fix it. Correct?
  1. yep, fixed
  2. Interesting, I haven't see this issue anywhere. Might be some VPN filtering out? Could you retry it ?
  3. yea for now it is like that
Liubov-crypto commented 1 month ago
  1. Fixed.

  2. I found the reason behind the images blocking:

icn img

janmichek commented 1 month ago
  1. Fixed.

I found the reason behind the images blocking:

icn img

Thanks, found the issue and fixed it.