aeternity / aescan

Block Explorer and Analytics Platform
ISC License
6 stars 3 forks source link

feat: Time format switch #720

Closed janmichek closed 4 months ago

janmichek commented 6 months ago

Description

resolves #697

Demo

https://github.com/aeternity/aescan/assets/15363559/c3813de0-a70d-4e1d-874d-b42cd7f77198

Checklist:

github-actions[bot] commented 6 months ago

Deployed to https://pr-720-aescan.stg.service.aepps.com and https://pr-720-aescan-testnet.stg.service.aepps.com

janmichek commented 6 months ago

Extra addition I made is adding clock icon as I saw this in referenced solutions. Let me know what you think. Can be removed easily image

janmichek commented 6 months ago

For unification in details, some refactoring needed to be done. Now it's separated into 2 rows. Height and time image

Exception has been made in Oracle detail as there are 4 time entries. So there keeps on one line image

Let me know if I should also separate it into block height and time per row

Liubov-crypto commented 5 months ago

When I opened it on the first time it has strange view and was placed inside grey bocks: https://github.com/aeternity/aescan/assets/69896204/626b5798-7df5-4e5a-a1e5-a1aad49631b3

after it's disappeared but aligning is not perfect yet:

123

janmichek commented 5 months ago

When I opened it on the first time it has strange view and was placed inside grey bocks: https://github.com/aeternity/aescan/assets/69896204/626b5798-7df5-4e5a-a1e5-a1aad49631b3

after it's disappeared but aligning is not perfect yet:

123

I am still working on it and running few experiments. Please wait for another round of review. I will request it from you

janmichek commented 5 months ago

In general LGTM.

I see that in almost all cases where time changes age, the alignment is slightly off (1 or 2 pixels). @janmichek could you check it please?

t al1 al 2024-04-09.1.44.46.mov

Fixed

janmichek commented 5 months ago

would still keep the tooltips so when one value is selected you can also hover and see the other one

Ok, no probs. Will do it.