feat: Display all testnet tokens

aeternity / aescan

Block Explorer and Analytics Platform

ISC License

6 stars 3 forks source link

feat: Display all testnet tokens #739

Closed janmichek closed 2 months ago

janmichek commented 2 months ago

Description

resolves #732

Demo

Checklist:

[x] I have read and followed the Contributing Guide
[x] disable listed tokens for testnet
[x] add N/A labels

github-actions[bot] commented 2 months ago

Deployed to https://pr-739-aescan.stg.service.aepps.com and https://pr-739-aescan-testnet.stg.service.aepps.com

janmichek commented 2 months ago

as folowup I created this https://github.com/aeternity/aescan/issues/742

janmichek commented 2 months ago

@Liubov-crypto all fixed, thanks for testing

Liubov-crypto commented 2 months ago

I have a question: is total supply and Amount of the tokens held by its owner shouldn't be the same? https://github.com/aeternity/aescan/assets/69896204/f5f977a9-79fd-416e-bff7-a75ce9402873

if the one account is holding all amount of tokens, then percentage field should be 100%?

https://github.com/aeternity/aescan/assets/69896204/804bd412-a2ed-4268-b096-20089cb28035

for example I can see Percentage on mainnet:

https://github.com/aeternity/aescan/assets/69896204/e3cb2a8c-701d-4b40-b183-abadcc49453e

michele-franchi commented 2 months ago

I have a question: is total supply and Amount of the tokens held by its owner shouldn't be the same? https://github.com/aeternity/aescan/assets/69896204/f5f977a9-79fd-416e-bff7-a75ce9402873

if the one account is holding all amount of tokens, then percentage field should be 100%?

2024-04-30.3.19.57.mov for example I can see Percentage on mainnet:

2024-04-30.3.24.15.mov

@janmichek did you already fix this issue?

janmichek commented 2 months ago

I have a question: is total supply and Amount of the tokens held by its owner shouldn't be the same? https://github.com/aeternity/aescan/assets/69896204/f5f977a9-79fd-416e-bff7-a75ce9402873 if the one account is holding all amount of tokens, then percentage field should be 100%? 2024-04-30.3.19.57.mov for example I can see Percentage on mainnet: 2024-04-30.3.24.15.mov

@janmichek did you already fix this issue?

Nope, there is some delicate bug :D it appears on PR preview, but works on localhost.

janmichek commented 2 months ago

Can we continue on the review here? https://github.com/aeternity/aescan/pull/783 I could not make it right here