feat: Add ISC license - Githubissues

aeternity / aescan

Block Explorer and Analytics Platform

ISC License

6 stars 3 forks source link

feat: Add ISC license #789

Closed janmichek closed 1 month ago

janmichek commented 1 month ago

Description

resolves https://github.com/aeternity/smart-contract-verifier/issues/55

Demo

Checklist:

[x] I have read and followed the Contributing Guide
[x] Add ISC license

github-actions[bot] commented 1 month ago

Deployed to https://pr-789-aescan.stg.service.aepps.com and https://pr-789-aescan-testnet.stg.service.aepps.com

Liubov-crypto commented 1 month ago

Smart Contracts verification doesn't work with ISC license: https://github.com/aeternity/aescan/assets/69896204/fc3a4e57-1753-4a69-bc26-075098f650ae

ver

or am I doing something wrong?

janmichek commented 1 month ago

Smart Contracts verification doesn't work with ISC license: https://github.com/aeternity/aescan/assets/69896204/fc3a4e57-1753-4a69-bc26-075098f650ae

or am I doing something wrong?

Thanks for testing it. All good from your side. ISC needs to be set in verifier service ass well then. I will fix it

janmichek commented 1 month ago

added on verifier side https://github.com/aeternity/smart-contract-verifier/pull/56 @michele-franchi

janmichek commented 1 month ago

It works for me now. You can retry @Liubov-crypto

Liubov-crypto commented 1 month ago

Tested on testnetwork, works fine. LGTM