aeternity / aescan

Block Explorer and Analytics Platform
ISC License
6 stars 3 forks source link

fix: Names in auction end date #799

Closed janmichek closed 1 month ago

janmichek commented 1 month ago

Description

fixes #794 fixes https://github.com/aeternity/aescan/issues/621

Major refactoring has been done. A detailed A/B check with production would be good.

Demo

https://github.com/aeternity/aescan/assets/15363559/a7257043-6452-464e-8ee7-47f052888468

Checklist:

github-actions[bot] commented 1 month ago

Deployed to https://pr-799-aescan.stg.service.aepps.com and https://pr-799-aescan-testnet.stg.service.aepps.com

github-actions[bot] commented 1 month ago

Deployed to https://pr-799-aescan.stg.service.aepps.com and https://pr-799-aescan-testnet.stg.service.aepps.com

Liubov-crypto commented 1 month ago

I'm still seeing meta.chain in auction and expired sections: https://pr-799-aescan.stg.service.aepps.com/names/meta.chain

could you please check it @janmichek ? https://github.com/aeternity/aescan/assets/69896204/ed455467-894a-40d8-b9cd-b9d2ec2e71a1

janmichek commented 1 month ago

I'm still seeing meta.chain in auction and expired sections: https://pr-799-aescan.stg.service.aepps.com/names/meta.chain

could you please check it @janmichek ? https://github.com/aeternity/aescan/assets/69896204/ed455467-894a-40d8-b9cd-b9d2ec2e71a1

Hmm, interesting. The name appears in both lists. I will escalate this to MDW team. For now ignore it.

janmichek commented 1 month ago

I'm still seeing meta.chain in auction and expired sections: https://pr-799-aescan.stg.service.aepps.com/names/meta.chain could you please check it @janmichek ? https://github.com/aeternity/aescan/assets/69896204/ed455467-894a-40d8-b9cd-b9d2ec2e71a1

Hmm, interesting. The name appears in both lists. I will escalate this to MDW team. For now ignore it.

I created followup on our side to track the issue https://github.com/aeternity/aescan/issues/802