feat: UI readability followup

aeternity / aescan

Block Explorer and Analytics Platform

ISC License

6 stars 3 forks source link

feat: UI readability followup #825

Closed janmichek closed 2 months ago

janmichek commented 4 months ago

Description

resolves #820

Demo

Checklist:

[x] I have read and followed the Contributing Guide
[x] UI fixes

github-actions[bot] commented 4 months ago

Deployed to https://pr-825-aescan.stg.service.aepps.com and https://pr-825-aescan-testnet.stg.service.aepps.com

janmichek commented 3 months ago

I noticed some issues are still not fixed.

1. Transaction details panels are not aligned on mobile:

2. Name details special pointers are not aligned on mobile:

I commented this before. I don't know what you want me to change, unless we pick different approach

janmichek commented 3 months ago

@michele-franchi https://github.com/aeternity/aescan/issues/820#issuecomment-2139416301 https://github.com/aeternity/aescan/issues/820#issuecomment-2139414929

michele-franchi commented 3 months ago

@janmichek I understand but when I look at the screen it seems there's a bug and I would expect things to be aligned the same way, for example:

I understand column widths are automatically calculated. Should we then maybe set a fixed height or a strategy to have them aligned?

janmichek commented 3 months ago

@janmichek I understand but when I look at the screen it seems there's a bug and I would expect things to be aligned the same way, for example:

I understand column widths are automatically calculated. Should we then maybe set a fixed height or a strategy to have them aligned?

I would better solve it with different approach mentioned in here https://github.com/aeternity/aescan/issues/786

michele-franchi commented 3 months ago

@janmichek isn't the issue you linked related to tables only? My screenshot is a panel.

janmichek commented 3 months ago

@janmichek isn't the issue you linked related to tables only? My screenshot is a panel.

The panel is technically table, right? Yes initially yes. My original idea was also to extend it to detail panels/tables. I clarified my idea to the issue. The problem partly is a big gap between mobile and desktop view. The app breaks to mobile view pretty early when it's limited by width in my opinion. SO you can get on 1200px width the mobile view which is not optimal at all. This can be fixed by adding a third view.

Currently, I don't have any quick solution to what you mentioned. Setting the fixed height you suggesting, will have a significant effect other elements, so we should expect more detailed work with layout. Should I proceed with it?

janmichek commented 2 months ago

I found that some issues are still reproducible for me:
1. Alignment in tx details:
2. Is it correct alignment for Names special pointers? from the description I understood that not:
3. Alignment of Data for Token events looks different on mobile:
4. Arguements is changing to Arguments on mobile:
https://github.com/user-attachments/assets/96e07996-ccd4-47fb-afd2-a872beb8fba8
5. Events for Oracles, alignments in Query details:

Thanks for the review ad points 1,2,5 - this is not easy to achieve. Previously in the discussion I created followup to do something conceptually different

the elements are laid automatically to maximize the space
fixed

Liubov-crypto commented 2 months ago

ad 4 has been fixed.