aeternity / aescan

Block Explorer and Analytics Platform
ISC License
6 stars 3 forks source link

feat: Top accounts #841

Closed janmichek closed 2 months ago

janmichek commented 3 months ago

Description

resolves #616

Demo

https://github.com/aeternity/aescan/assets/15363559/2087fa57-f8d8-4090-91ac-2f3c69223780

Checklist:

github-actions[bot] commented 3 months ago

Deployed to https://pr-841-aescan.stg.service.aepps.com and https://pr-841-aescan-testnet.stg.service.aepps.com

Liubov-crypto commented 3 months ago

is this feature only for mainnet accounts?

it might be worth adding a period at the end of the sentence to make it the same as the other sentences:

bal

the rest LGTM.

janmichek commented 3 months ago

is this feature only for mainnet accounts?

No, why? Different networks has different responses.

it might be worth adding a period at the end of the sentence to make it the same as the other sentences:

Sure, fixed. Thanks

janmichek commented 3 months ago

@michele-franchi I was thinking about shortening the list to 100 (just print half of it), as the lower half does not have very important entries

michele-franchi commented 3 months ago

Agree @janmichek, makes sense.

janmichek commented 3 months ago

Agree @janmichek, makes sense.

fixed