search

aeternity / bounties

Rewarded contribution opportunities in the æcosystem for the æternity community.
4 stars 2 forks source link

Angular Boilerplate #5

Open kenodressel opened 3 years ago

kenodressel commented 3 years ago

Hey Community!

This is our bounty to create a angular boilerplate. We want to keep the added noise minimal which is why we only want a working SDK integration at the moment. We might want to expand this further in the future but this should serve as a baseline.

To claim this bounty please comment here in the issue and provide a timeline.

YinkaEnoch commented 3 years ago

@kenodressel, I would love to work on this bounty. The project should be ready on/before Nov. 12

ErkanKanden commented 2 years ago

Hi @YinkaEnoch, you can start working on this task. Please let us know here if you have any questions

ErkanKanden commented 2 years ago

@YinkaEnoch are you working on this bounty?

YinkaEnoch commented 2 years ago

Apologies for not informing you earlier that I started working on the bounty already. I faced a couple of issues but I'm moving past them as they come. I should be done in a day or two

nikita-fuchs commented 2 years ago

Hey @YinkaEnoch , I know I'm late to the party, but can I ask for the SDK to be put in a separate service in your angular boilerplate, please? That would be really lovely.

YinkaEnoch commented 2 years ago

Noted

YinkaEnoch commented 2 years ago

The project is now live on https://github.com/YinkaEnoch/aepp-boilerplate-angular

YinkaEnoch commented 2 years ago

The code can now be reviewed for bugs and/or feedback

ErkanKanden commented 2 years ago

@nikita-fuchs Please review the Angular boilerplate if you have a moment.

nikita-fuchs commented 2 years ago

sliding back from OOO little by little, let me take a look...

nikita-fuchs commented 2 years ago

Seems like a solid start ! :) Please take care of a few scenarios though:

It would be cool if the info would not only be logged to console, but shown in the UI, too.

And I know it's not part of the original criteria, but you get extra karma points if you include a functionality to transfer AE to some address :) !

EDIT: One current issue around the wallet connection (it's our fault) is that the wallet connection is assuming that the superhero wallet is connected to the node and network you set up the SDK with. I don't know if there is a way to detect if wallet and sdk are set up to ne on the same network, to be honest. we are working on fixing this right now, sorry.

YinkaEnoch commented 2 years ago

How do I reproduce the 2nd scenario?

nikita-fuchs commented 2 years ago

If you mean

What if the account in the wallet does not exist on chain yet ? The code breaks with an error in that case.

Well - just generate a brand new account not used on the chain yet

thepiwo commented 2 years ago

Looks really good to me, I think additional error handling steps are out of scope for this bounty.

marc0olo commented 2 years ago

@ErkanKanden I think we can proceed with the bounty then :-)

sorry for the delay @YinkaEnoch and thanks for the contribution!

as a small sidenote => we're close to release v11.0.0 of the SDK. would be cool if you could update the dependency in the boilerplate after that happened. but it's not required to receive the bounty

ErkanKanden commented 2 years ago

@YinkaEnoch Please provide your AE wallet address here as a comment to receive the bounty reward. Thanks for your efforts and patience and we would be very thankful if you could update to SDK v11.0.0 when possible.

YinkaEnoch commented 2 years ago

ak_FfUXsy5X39FYaaWPs3tKBibc4tN1XFoyqDEz9fWybv7j129QR

YinkaEnoch commented 2 years ago

I'd make the update as soon as it is ready. In the mean time, I'd also push the updates I've worked on, to address one or two of the issue(s) @nikita-fuchs raised

marc0olo commented 2 years ago

sounds good, thank you! :)

marc0olo commented 2 years ago

@ErkanKanden did you proceed with the payout? can we close?

ErkanKanden commented 2 years ago

@YinkaEnoch Here is your well deserved reward! Sorry for the inconviences. Looking forward to your next contributions and please keep us updated if you could implement the JS SDK update in the boilerplate.